I love this Rails PR (and the original code it removes).

Some crazy optimisations/shenanigans were introduced but:

• it was well documented
• it solved an actual need (a hotspot in frequently used framework code)
• it was removed once no longer needed

Open source done well!